[https://nvbugs/6550803][fix] Pin Mock(_force_non_greedy_for_capture=False) at the test's spec_metadata… - #17219
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe integration waiver entry for Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…pling override Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
8bc84eb to
7fcbbc6
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/bot run --disable-fail-fast |
|
PR_Github #65397 [ run ] triggered by Bot. Commit: |
|
PR_Github #65397 [ run ] completed with state |
|
/bot run --disable-fail-fast |
Summary
Mock()asspec_metadata, sogetattr(spec_metadata, '_force_non_greedy_for_capture', False)returned a truthy auto-vivified child Mock instead ofFalse, tripping the production assert that guards the capture-only sampling override.Mock(_force_non_greedy_for_capture=False)at the test's spec_metadata double (the convention already used at line 231 of the same file), leaving the production guard intact, and remove the obsolete waiver.Test plan
Links
Dev Engineer Review
PyTorchModelEngineTestCase::test_promoted_context_precedes_speculative_overlap_generation.tests/integration/test_lists/waives.txt.Mock(_force_non_greedy_for_capture=False)to prevent unintended truthiness fromMockattribute auto-vivification.QA Engineer Review
tests/integration/test_lists/waives.txt.unittest/_torch/executor/test_pytorch_model_engine.py::PyTorchModelEngineTestCase::test_promoted_context_precedes_speculative_overlap_generation.test-db/orqa/files were modified.